Update Dockerfile to pull manifests from different component repo #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
force-pushed
the
issue/424
branch
4 times, most recently
from
cfef6a3
to
2f9ed14
Compare
zdtsw
force-pushed
the
issue/424
branch
5 times, most recently
from
559d9c8
to
7f7be0c
Compare
|
/hold Till we get update from components and corresponding ADR is merged |
should we get this one out first and keep migrating the rest 2 components? |
|
/test opendatahub-operator-e2e |
|
/test opendatahub-operator-e2e |
|
/hold need to get opendatahub-io/notebooks#186 in first |
|
/unhold notebook-images has been updated to get manifets from opendatahub-io/notebooks |
5 tasks
- leave notebook, modelmesh, monitoring as-is from odh-manifests - change kserve path to where it sets in source repo. - move download manifests function into a script - make Dockerfile a multi-stage build - add empty odh-amnifests for ci build - odh-modelmesh-controller has new path in odh-manifests - kserve does not have 'base' in component repo Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
- see https://github.com/opendatahub-io/odh-manifests/blob/master/kserve/hack/kustomization.yaml Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: etirelli, VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Sep 29, 2023
…endatahub-io#431) * Update Dockerfile to pull manifests from different component repo - leave notebook, modelmesh, monitoring as-is from odh-manifests - change kserve path to where it sets in source repo. - move download manifests function into a script - make Dockerfile a multi-stage build - add empty odh-amnifests for ci build - odh-modelmesh-controller has new path in odh-manifests - kserve does not have 'base' in component repo Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update kserve release branch Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update manifests path for kserve - see https://github.com/opendatahub-io/odh-manifests/blob/master/kserve/hack/kustomization.yaml Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update notebook-images to use manifests from its repo Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Fix: path for kserve Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Docs: update README Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 6880557)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Sep 29, 2023
…endatahub-io#431) * Update Dockerfile to pull manifests from different component repo - leave notebook, modelmesh, monitoring as-is from odh-manifests - change kserve path to where it sets in source repo. - move download manifests function into a script - make Dockerfile a multi-stage build - add empty odh-amnifests for ci build - odh-modelmesh-controller has new path in odh-manifests - kserve does not have 'base' in component repo Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update kserve release branch Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update manifests path for kserve - see https://github.com/opendatahub-io/odh-manifests/blob/master/kserve/hack/kustomization.yaml Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update notebook-images to use manifests from its repo Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Fix: path for kserve Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Docs: update README Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 6880557)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_all_aminfests.shref: #424
How Has This Been Tested?
UPDATES:
new local build image: from 14th Sep quay.io/wenzhou/opendatahub-operator-catalog:v2.9.424
OLD:
Merge criteria: